Password limit is set to 60 characters

snowe@programming.dev · 1 year ago

Password limit is set to 60 characters

micahmo@programming.dev · 1 year ago

Hi all,

Continuing the discussion from GitHub… Here is the PR I opened.

https://github.com/thunder-app/thunder/pull/766

However, there’s still some discussion to be had about whether this is the right change.

@snowe, a couple questions…

Can you log in via Liftoff? They also have a 60 char limit. https://github.com/liftoff-app/liftoff/blob/3055896657ef05772dc5fa18c5b3ab285b93f54a/lib/pages/settings/add_account_page.dart#L199
When you say, “It seems like the password limit is set to 60 characters so I’m unable to login to my instance.”, did you try logging in with a truncated password? Or are you just assuming that, if we limit the length, it won’t work? I only ask because this Thunder discussion led us to find that truncating actually works for some users, which is what led to the original limit.

Thanks!!

darklightxi@lemmy.world · 1 year ago

I believe Jerboa also has this character limit as mentioned in this PR. It seems like they truncate the password to take the first 60 characters if it’s too long. This is what Thunder also follows as of right now, except it’s shown explicitly to the user in the login modal