Exactly that! Everyone can See “what” is happening, the code is right there. But the code usually doesn’t tell you “why” that is happening - good comments help understand the authors intent and give context, so you don’t have to guess.
Good comments should explain the things that are not obvious.
Good comments more than once prevented me from accidentially undoing a fix.
ok, so if i read this correctly, then the p2pool folks say: if you have 10 MBit/s or more use 32 in-peers (that’s 40KB/s per in-peer). Don’t use more than 1000 because of the linux file limit (which can be changed)
So according to their numbers, with my 20 MBit/s limit i set i should choose about 64 in-peers.
I just looked at the upload-traffic of the last 21 hours. In total i used 44.55 GB of upload-bandwidth in that time, which is about 4.71 MBit/s or 603 KB/s. There were about 130-140 connected peers in that time. That equals about 0.03492 MBit/s or 4.47 KB/s per connected in-peer
With my 20 MBit/s limit that should allow for ~573 peers. This is average speed though, and there are probably spikes in network usage all the time. So if i apply a buffer of ~50% i should be able to serve about 256 in-peers with an average of 10 KB/s per in-peer.
I’ll set it to 64 out and 256 in and let it run a couple of days and see how it goes :)
There have not yet been more than 150 connected peers anyway
That’s kinda what i want to find out - how much bandwidth does a peer need on average?
Thanks for pointing out monerod print_net_stats! Will leave it running for a day or two and see how much is used.
Currently the network usage is minimal, but that is probably because i only increased the peer-count 2 hours ago.
get some Monero and use it in the real world economy
easier said than done, but i do keep my eyes open for opportunities to use monero instead of other currencies. My next mullvad payment will be in monero
If the comments tell you “what” happens, then yes, they can geht outdated fast. The details of how something works can change quickly.
But comments documenting “why” something is done (a certain way) - explaining the intent - are probably valid for mich longer.
In the best case comments aren’t viewed as something that is seperate from the code, but part of it. So that if someone changes the code, the comments has to be checked aswell (if the explanation of “why” something is done actually changed).