Thomas Glexiner of Linutronix (now owned by Intel) has posted 58 patches for review into the Linux kernel, but they’re only the beginning! Most of the patches are just first steps at doing more major renovations into what he calls “decrapification”. He says:
While working on a sane topology evaluation mechanism, which addresses the short-comings of the existing tragedy held together with duct-tape and hay-wire, I ran into the issue that quite some of this tragedy is deeply embedded in the APIC code and uses an impenetrable maze of callbacks which might or might not be correct at the point where the CPUs are registered via MPPARSE or ACPI/MADT.
So I stopped working on the topology stuff and decided to do an overhaul of the APIC code first. Cleaning up old gunk which dates back to the early SMP days, making the CPU registration halfways understandable and then going through all APIC callbacks to figure out what they actually do and whether they are required at all. There is also quite some overhead through the indirect calls and some of them are actually even pointlessly indirected twice. At some point Peter yelled static_call() at me and that’s what I finally ended up implementing.
He also, at one point, (half-heartedly) argues for the removal of 32-bit x86 code entirely, arguing that it would simplify APIC code and reduce the chance for introducing bugs in the future:
Talking about those museums pieces and the related historic maze, I really have to bring up the question again, whether we should finally kill support for the museum CPUs and move on.
Ideally we remove 32bit support alltogether. I know the answer… :(
But what I really want to do is to make x86 SMP only. The amount of #ifdeffery and hacks to keep the UP support alive is amazing. And we do this just for the sake that it runs on some 25+ years old hardware for absolutely zero value. It’d be not the first architecture to go SMP=y.
Yes, we “support” Alpha, PARISC, Itanic and other oddballs too, but that’s completely different. They are not getting new hardware every other day and the main impact on the kernel as a whole is mostly static. They are sometimes in the way of generalizing things in the core code. Other than that their architecture code is self contained and they can tinker on it as they see fit or let it slowly bitrot like Itanic.
But x86 is (still) alive and being extended and expanded. That means that any refactoring of common infrastructure has to take the broken hardware museum into account. It’s doable, but it’s not pretty and of really questionable value. I wouldn’t mind if there were a bunch of museum attendants actively working on it with taste, but that’s obviously wishful thinking. We are even short of people with taste who work on contemporary hardware support…
While I cursed myself at some point during this work for having merged i386/x86_64 back then, I still think that it was the correct decision at that point in time and saved us a lot of trouble. It admittedly added some trouble which we would not have now, but it avoided the insanity of having to maintain two trees with different bugs and “fixes” for the very same problems. TBH quite some of the horrors which I just removed came out of the x86/64 side. The oddballs of i386 early SMP support are a horror on their own of course.
As we made that decision more than 15 years [!] ago, it’s about time to make new decisions.
Linus responded to one of the patches, saying “I’m cheering your patch series”, but has obviously diplomatically not acknowledged the plea to remove 32-bit support.
Of course he didn’t respond to the 32bit removal, he made his stance pretty clear over a decade ago. The author even said he knew what the answer would be, because how could you be a kernel maintainer without knowing about that email.
Do you have a link to that email?
addresses the short-comings of the existing tragedy held together with duct-tape and hay-wire
My god, “Addressing the existing tragedy” is a phrase I didn’t know I needed until now
I’d imagine there aren’t many people in the world who could even attempt to clean up such code. since I don’t use such old hardware and I think such old hardware for the most part does not use kernels >= 6.5, I concur with this removal
Thanks for the summary!